[v8-dev] The value register in storefield(smi) is not used as a temp (issue 551803005 by [email protected])

Tue, 16 Sep 2014 01:59:02 -0700 

Reviewers: Igor Sheludko,

Message:
PTAL

Description:
The value register in storefield(smi) is not used as a temp
BUG=

Please review this at https://codereview.chromium.org/551803005/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files (+3, -9 lines):
  M src/arm/lithium-arm.cc
  M src/ia32/lithium-ia32.cc
  M src/mips/lithium-mips.cc
  M src/mips64/lithium-mips64.cc
  M src/x64/lithium-x64.cc
  M src/x87/lithium-x87.cc


Index: src/arm/lithium-arm.cc
diff --git a/src/arm/lithium-arm.cc b/src/arm/lithium-arm.cc
index 7b97cb889e6619a4b3cf13cfcf1e4f828f96d8f4..9db5bd6678777d5e0e4cab41d44a76183876a201 100644 
--- a/src/arm/lithium-arm.cc
+++ b/src/arm/lithium-arm.cc
@@ -2362,7 +2362,7 @@ LInstruction* LChunkBuilder::DoStoreNamedField(HStoreNamedField* instr) { 
   }

   LOperand* val;
-  if (needs_write_barrier || instr->field_representation().IsSmi()) {
+  if (needs_write_barrier) {
     val = UseTempRegister(instr->value());
   } else if (instr->field_representation().IsDouble()) {
     val = UseRegisterAtStart(instr->value());
Index: src/ia32/lithium-ia32.cc
diff --git a/src/ia32/lithium-ia32.cc b/src/ia32/lithium-ia32.cc
index 0db3d9cae6fc423281d4359d836966a2584b3f82..9b8970e4f11b0b299349d185b37e465e08da7017 100644 
--- a/src/ia32/lithium-ia32.cc
+++ b/src/ia32/lithium-ia32.cc
@@ -2414,8 +2414,6 @@ LInstruction* LChunkBuilder::DoStoreNamedField(HStoreNamedField* instr) { 
     val = UseTempRegister(instr->value());
   } else if (can_be_constant) {
     val = UseRegisterOrConstant(instr->value());
-  } else if (instr->field_representation().IsSmi()) {
-    val = UseTempRegister(instr->value());
   } else if (instr->field_representation().IsDouble()) {
     val = UseRegisterAtStart(instr->value());
   } else {
Index: src/mips/lithium-mips.cc
diff --git a/src/mips/lithium-mips.cc b/src/mips/lithium-mips.cc
index 6b910233bcb63e98e9bbe49e306c613f46a0e461..904ffa56dddcf390f0a1dbf9cf0382c242e8d055 100644 
--- a/src/mips/lithium-mips.cc
+++ b/src/mips/lithium-mips.cc
@@ -2311,7 +2311,7 @@ LInstruction* LChunkBuilder::DoStoreNamedField(HStoreNamedField* instr) { 
   }

   LOperand* val;
-  if (needs_write_barrier || instr->field_representation().IsSmi()) {
+  if (needs_write_barrier) {
     val = UseTempRegister(instr->value());
   } else if (instr->field_representation().IsDouble()) {
     val = UseRegisterAtStart(instr->value());
Index: src/mips64/lithium-mips64.cc
diff --git a/src/mips64/lithium-mips64.cc b/src/mips64/lithium-mips64.cc
index a7af7e0720e96a006bb47c347bf56379491efb6e..214748cf862558908b1cda13b458a3962f6ab3b7 100644 
--- a/src/mips64/lithium-mips64.cc
+++ b/src/mips64/lithium-mips64.cc
@@ -2311,7 +2311,7 @@ LInstruction* LChunkBuilder::DoStoreNamedField(HStoreNamedField* instr) { 
   }

   LOperand* val;
-  if (needs_write_barrier || instr->field_representation().IsSmi()) {
+  if (needs_write_barrier) {
     val = UseTempRegister(instr->value());
   } else if (instr->field_representation().IsDouble()) {
     val = UseRegisterAtStart(instr->value());
Index: src/x64/lithium-x64.cc
diff --git a/src/x64/lithium-x64.cc b/src/x64/lithium-x64.cc
index b7b13867d364db65ae469f54f6b2e7e997ed851f..815038b9e699d2fa053f8c9b912da22e9045166b 100644 
--- a/src/x64/lithium-x64.cc
+++ b/src/x64/lithium-x64.cc
@@ -2398,8 +2398,6 @@ LInstruction* LChunkBuilder::DoStoreNamedField(HStoreNamedField* instr) { 
     val = UseFixed(instr->value(), rax);
   } else if (can_be_constant) {
     val = UseRegisterOrConstant(instr->value());
-  } else if (instr->field_representation().IsSmi()) {
-    val = UseRegister(instr->value());
   } else if (instr->field_representation().IsDouble()) {
     val = UseRegisterAtStart(instr->value());
   } else {
Index: src/x87/lithium-x87.cc
diff --git a/src/x87/lithium-x87.cc b/src/x87/lithium-x87.cc
index b9488d96cf7d86917978d1a3c94e17221b328b18..02037c3b0861752d066ce75689ad920e4ce1e9a0 100644 
--- a/src/x87/lithium-x87.cc
+++ b/src/x87/lithium-x87.cc
@@ -2389,8 +2389,6 @@ LInstruction* LChunkBuilder::DoStoreNamedField(HStoreNamedField* instr) { 
     val = UseTempRegister(instr->value());
   } else if (can_be_constant) {
     val = UseRegisterOrConstant(instr->value());
-  } else if (instr->field_representation().IsSmi()) {
-    val = UseTempRegister(instr->value());
   } else if (instr->field_representation().IsDouble()) {
     val = UseRegisterAtStart(instr->value());
   } else {


--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group. 
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to