Revision: 23969
Author:   [email protected]
Date:     Tue Sep 16 09:47:45 2014 UTC
Log:      The value register in storefield(smi) is not used as a temp
BUG=
[email protected]

Review URL: https://codereview.chromium.org/551803005
https://code.google.com/p/v8/source/detail?r=23969

Modified:
 /branches/bleeding_edge/src/arm/lithium-arm.cc
 /branches/bleeding_edge/src/ia32/lithium-ia32.cc
 /branches/bleeding_edge/src/mips/lithium-mips.cc
 /branches/bleeding_edge/src/mips64/lithium-mips64.cc
 /branches/bleeding_edge/src/x64/lithium-x64.cc
 /branches/bleeding_edge/src/x87/lithium-x87.cc

=======================================
--- /branches/bleeding_edge/src/arm/lithium-arm.cc Thu Sep 11 07:11:10 2014 UTC +++ /branches/bleeding_edge/src/arm/lithium-arm.cc Tue Sep 16 09:47:45 2014 UTC
@@ -2362,7 +2362,7 @@
   }

   LOperand* val;
-  if (needs_write_barrier || instr->field_representation().IsSmi()) {
+  if (needs_write_barrier) {
     val = UseTempRegister(instr->value());
   } else if (instr->field_representation().IsDouble()) {
     val = UseRegisterAtStart(instr->value());
=======================================
--- /branches/bleeding_edge/src/ia32/lithium-ia32.cc Thu Sep 11 07:11:10 2014 UTC +++ /branches/bleeding_edge/src/ia32/lithium-ia32.cc Tue Sep 16 09:47:45 2014 UTC
@@ -2414,8 +2414,6 @@
     val = UseTempRegister(instr->value());
   } else if (can_be_constant) {
     val = UseRegisterOrConstant(instr->value());
-  } else if (instr->field_representation().IsSmi()) {
-    val = UseTempRegister(instr->value());
   } else if (instr->field_representation().IsDouble()) {
     val = UseRegisterAtStart(instr->value());
   } else {
=======================================
--- /branches/bleeding_edge/src/mips/lithium-mips.cc Thu Sep 11 12:13:09 2014 UTC +++ /branches/bleeding_edge/src/mips/lithium-mips.cc Tue Sep 16 09:47:45 2014 UTC
@@ -2311,7 +2311,7 @@
   }

   LOperand* val;
-  if (needs_write_barrier || instr->field_representation().IsSmi()) {
+  if (needs_write_barrier) {
     val = UseTempRegister(instr->value());
   } else if (instr->field_representation().IsDouble()) {
     val = UseRegisterAtStart(instr->value());
=======================================
--- /branches/bleeding_edge/src/mips64/lithium-mips64.cc Thu Sep 11 12:13:09 2014 UTC +++ /branches/bleeding_edge/src/mips64/lithium-mips64.cc Tue Sep 16 09:47:45 2014 UTC
@@ -2311,7 +2311,7 @@
   }

   LOperand* val;
-  if (needs_write_barrier || instr->field_representation().IsSmi()) {
+  if (needs_write_barrier) {
     val = UseTempRegister(instr->value());
   } else if (instr->field_representation().IsDouble()) {
     val = UseRegisterAtStart(instr->value());
=======================================
--- /branches/bleeding_edge/src/x64/lithium-x64.cc Thu Sep 11 07:11:10 2014 UTC +++ /branches/bleeding_edge/src/x64/lithium-x64.cc Tue Sep 16 09:47:45 2014 UTC
@@ -2398,8 +2398,6 @@
     val = UseFixed(instr->value(), rax);
   } else if (can_be_constant) {
     val = UseRegisterOrConstant(instr->value());
-  } else if (instr->field_representation().IsSmi()) {
-    val = UseRegister(instr->value());
   } else if (instr->field_representation().IsDouble()) {
     val = UseRegisterAtStart(instr->value());
   } else {
=======================================
--- /branches/bleeding_edge/src/x87/lithium-x87.cc Fri Sep 12 06:41:13 2014 UTC +++ /branches/bleeding_edge/src/x87/lithium-x87.cc Tue Sep 16 09:47:45 2014 UTC
@@ -2389,8 +2389,6 @@
     val = UseTempRegister(instr->value());
   } else if (can_be_constant) {
     val = UseRegisterOrConstant(instr->value());
-  } else if (instr->field_representation().IsSmi()) {
-    val = UseTempRegister(instr->value());
   } else if (instr->field_representation().IsDouble()) {
     val = UseRegisterAtStart(instr->value());
   } else {

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to