https://codereview.chromium.org/553413002/diff/20001/src/array.js
File src/array.js (right):

https://codereview.chromium.org/553413002/diff/20001/src/array.js#newcode1139
src/array.js:1139: if (!IS_NULL_OR_UNDEFINED(receiver) &&
On 2014/09/16 10:45:46, Diego Pino wrote:
On 2014/09/12 16:29:17, arv wrote:
> Can this test be moved out of the loop?

In strict mode, GetDefaultReceiver can return 'undefined'. ToObject
throws an
exception if the argument is undefined, so I need to avoid that case.

I think Erik was referring to the test, not the body of the test.

e.g.

var needs_wrapper = ...;

for () {
  var new_receiver = needs_wrapper ? ToObject(receiver) : receiver;
  ...
}

https://codereview.chromium.org/553413002/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to