LGTM, two nits
https://codereview.chromium.org/572293002/diff/20001/src/counters.h
File src/counters.h (right):
https://codereview.chromium.org/572293002/diff/20001/src/counters.h#newcode297
src/counters.h:297: HR(gc_idle_time_limit_exceeded,
V8.GCIdleTimeLimitExceeded, 0, 10000, 101) \
For me, overshot and undershot would be clearer. Exceeded is fine but
missed is so overloaded.
https://codereview.chromium.org/572293002/diff/20001/src/heap/heap.cc
File src/heap/heap.cc (right):
https://codereview.chromium.org/572293002/diff/20001/src/heap/heap.cc#newcode4357
src/heap/heap.cc:4357: }
What about the perfect sample? Should we add it to the "undershot"
histogram?
https://codereview.chromium.org/572293002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
