LGTM with comments (which apply to all platforms).
https://codereview.chromium.org/578583002/diff/20001/src/ia32/lithium-codegen-ia32.cc
File src/ia32/lithium-codegen-ia32.cc (right):
https://codereview.chromium.org/578583002/diff/20001/src/ia32/lithium-codegen-ia32.cc#newcode4766
src/ia32/lithium-codegen-ia32.cc:4766: __ jmp(done);
As discussed, we don't need this jump (as it would jump to the very next
instruction, which is the jump to the deferred code's exit label).
https://codereview.chromium.org/578583002/diff/20001/src/ia32/lithium-codegen-ia32.cc#newcode4790
src/ia32/lithium-codegen-ia32.cc:4790: __ jmp(done);
This can go too (see above).
https://codereview.chromium.org/578583002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
