On 2014/09/17 11:30:03, wingo wrote:
lgtm; a test would be nice, though I know how irritating debugger tests
can be
https://codereview.chromium.org/544953005/diff/1/src/generator.js
File src/generator.js (right):
https://codereview.chromium.org/544953005/diff/1/src/generator.js#newcode23
src/generator.js:23: if
(DEBUG_IS_ACTIVE) %DebugPrepareStepInIfStepping(this);
Is this needed at almost every use of %_CallFunction? Looks to me like
there
are more of these sites needing %DebugPrepareStepInIfStepping in the
runtime
.js
files that are unrelated to generators.
Debug::PrepareStep ignores native javascript. So in case where we call out
to
user JS, that should be done. This is used in many cases, for example
Array.prototype.forEach, but in some cases we don't like
Array.prototype.sort.
So far nobody complained yet, but we can always consider to add them if
demanded.
https://codereview.chromium.org/544953005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
