Almost there ...
https://codereview.chromium.org/573703002/diff/180001/src/compiler/js-inlining.cc
File src/compiler/js-inlining.cc (right):
https://codereview.chromium.org/573703002/diff/180001/src/compiler/js-inlining.cc#newcode340
src/compiler/js-inlining.cc:340: static void
AddClosureToFrameState(JSGraph* jsgraph, Node* frame_state,
nit: This could be turned into a member method in JSInliner, avoiding
the need to pass the JSGraph around.
https://codereview.chromium.org/573703002/diff/180001/src/compiler/js-inlining.cc#newcode350
src/compiler/js-inlining.cc:350: static Node*
CreateArgumentsAdaptorFrameState(JSGraph* jsgraph,
nit: This could be turned into a member method in JSInliner, avoiding
the need to pass the JSGraph and the Zone around.
https://codereview.chromium.org/573703002/diff/180001/src/compiler/js-inlining.cc#newcode449
src/compiler/js-inlining.cc:449: outer_frame_state =
CreateArgumentsAdaptorFrameState(
This create a new arguments-adaptor FrameState for every inner
FrameState. I think we should be able to share the arguments adaptor
(i.e. create only one per call-site).
https://codereview.chromium.org/573703002/diff/180001/test/cctest/cctest.status
File test/cctest/cctest.status (right):
https://codereview.chromium.org/573703002/diff/180001/test/cctest/cctest.status#newcode84
test/cctest/cctest.status:84: 'test-debug/DebugEvaluateWithoutStack':
[PASS, NO_VARIANTS],
Please don't re-introduce these exceptions, they shouldn't be needed
anymore. If they are then something is wrong.
https://codereview.chromium.org/573703002/diff/180001/test/cctest/cctest.status#newcode95
test/cctest/cctest.status:95: 'test-run-inlining/*': [PASS,
NO_VARIANTS],
If they do the same, then let's just run them on all variants. They
should not be long running.
https://codereview.chromium.org/573703002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
