https://codereview.chromium.org/583593006/diff/1/src/heap/gc-idle-time-handler.cc
File src/heap/gc-idle-time-handler.cc (right):
https://codereview.chromium.org/583593006/diff/1/src/heap/gc-idle-time-handler.cc#newcode100
src/heap/gc-idle-time-handler.cc:100: idle_time_in_ms >
kMaxFrameRenderingIdleTime) {
that is 16 < idle_time_in_ms < 10 which is always false
https://codereview.chromium.org/583593006/diff/1/src/heap/gc-idle-time-handler.cc#newcode111
src/heap/gc-idle-time-handler.cc:111: if (idle_time_in_ms <
current_scavenging_estimate_in_ms) return false;
so basically, we force a scavenge if it would take between 10 and 16 ms,
right?
i thought this method should return true if we should scavenge now if
the next regular scavenge might be more than 10ms?
https://codereview.chromium.org/583593006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
