On 2014/09/18 22:24:52, jarin wrote:
How about wrapping "const char* reason" in a class? I can easily imagine
that
we
might want to impose more structure on the deopt information later;
having a
wrapper would make this simpler. (I understand that ultimately we will
want to
thread the deopt reason through generated code, so the wrapper might not
be
completely trivial.)
I thought about something similar, too, but I wasn't sure if it's worth it
or if
it would complicate things more. If we do it, I think the mnemonic/reason
pair
should be in that class, perhaps even a source position?
My proposal would be: Land this CL as it is and introduce the class in a
separate CL (if it works out).
https://codereview.chromium.org/582743002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
