The test makes calls to a heuristic API method and expects predictable
results.
After https://codereview.chromium.org/576093002/ its innate flakiness has
become
more obvious.
If you run with GC tracing flags you can see that the GC system is choosing
to
only perform a newspace collection when advised that there is idle time.
That
seems fundamentally OK, so the test should not expect all garbage to be
found.
Output from a trace:
=== cctest/test-api/Regress2107 ===
initial_size: 883260
[25849] 3 ms: Mark-sweep 0.8 (18.1) -> 0.8 (18.1) MB, 2.0 ms [idle
notification: finalize idle round] [GC in old space requested].
Idle notification: requested idle time 1000 ms, actual time 2 ms [full GC]
[25849] 8 ms: Mark-sweep 4.8 (22.1) -> 0.8 (19.1) MB, 2.0 ms [idle
notification: contexts disposed] [GC in old space requested].
Idle notification: requested idle time 1000 ms, actual time 2 ms [full GC]
[25849] 11 ms: Mark-sweep 4.8 (22.1) -> 0.8 (20.1) MB, 1.7 ms [idle
notification: contexts disposed] [GC in old space requested].
Idle notification: requested idle time 1000 ms, actual time 1 ms [full GC]
[25849] 15 ms: Mark-sweep 4.8 (23.1) -> 0.8 (20.1) MB, 1.7 ms [idle
notification: contexts disposed] [GC in old space requested].
Idle notification: requested idle time 1000 ms, actual time 1 ms [full GC]
[25849] 18 ms: Mark-sweep 4.8 (23.1) -> 0.8 (20.1) MB, 1.7 ms [idle
notification: contexts disposed] [GC in old space requested].
Idle notification: requested idle time 1000 ms, actual time 1 ms [full GC]
[25849] 21 ms: Mark-sweep 4.8 (23.1) -> 0.8 (20.1) MB, 1.6 ms [idle
notification: contexts disposed] [GC in old space requested].
Idle notification: requested idle time 1000 ms, actual time 1 ms [full GC]
[25849] 24 ms: Mark-sweep 4.8 (23.1) -> 0.8 (20.1) MB, 1.7 ms [idle
notification: contexts disposed] [GC in old space requested].
Idle notification: requested idle time 1000 ms, actual time 1 ms [full GC]
[25849] 26 ms: Scavenge 4.8 (23.1) -> 4.8 (23.1) MB, 0.2 ms [idle
notification: scavenge].
Idle notification: requested idle time 1000 ms, actual time 0 ms [scavenge]
[25849] 29 ms: Scavenge 8.6 (26.1) -> 8.6 (27.1) MB, 0.3 ms [idle
notification: scavenge].
[IncrementalMarking] Start
[IncrementalMarking] Start sweeping.
Idle notification: requested idle time 1000 ms, actual time 0 ms [scavenge]
Idle notification: requested idle time 1000 ms, actual time 0 ms [done]
final_size: 9021160
#
# Fatal error in ../test/cctest/test-api.cc, line 17854
# CHECK((final_size) < (initial_size + 1)) failed
#
https://codereview.chromium.org/580413002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
