Reviewers: Weiliang,
Message:
wl.
ptal.
thanks
Description:
X87: When serializer is enalbed, we disable the X87 stack check to reduce
the
code size.
The reason is that the big code size will leads to test-serialize test
cases fail
when debug mode and snapshot=off.
BUG=
Please review this at https://codereview.chromium.org/582373002/
SVN Base: https://chromium.googlesource.com/external/v8.git@bleeding_edge
Affected files (+3, -0 lines):
M src/x87/macro-assembler-x87.cc
Index: src/x87/macro-assembler-x87.cc
diff --git a/src/x87/macro-assembler-x87.cc b/src/x87/macro-assembler-x87.cc
index
8c929e497f358ada238af19bb4b79bd837460e95..66f57033434a10779f30d45657e4ad8d084031a5
100644
--- a/src/x87/macro-assembler-x87.cc
+++ b/src/x87/macro-assembler-x87.cc
@@ -2471,6 +2471,9 @@ void MacroAssembler::Ret(int bytes_dropped, Register
scratch) {
void MacroAssembler::VerifyX87StackDepth(uint32_t depth) {
+ // Turn off the stack depth check when serializer is enabled to reduce
the
+ // code size.
+ if (serializer_enabled()) return;
// Make sure the floating point stack is either empty or has depth items.
DCHECK(depth <= 7);
// This is very expensive.
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
