On 2014/09/19 11:40:59, Michael Starzinger wrote:
LGTM.
https://codereview.chromium.org/582703002/diff/1/src/scopes.cc
File src/scopes.cc (right):
https://codereview.chromium.org/582703002/diff/1/src/scopes.cc#newcode164
src/scopes.cc:164: asm_function_ = outer_scope != NULL &&
outer_scope->asm_module_;
On 2014/09/19 11:38:21, titzer wrote:
> On 2014/09/18 19:12:34, Michael Starzinger wrote:
> > This only applies of the scope_type is FUNCTION_SCOPE. Wouldn't false
as a
> > default value suffice here anyways?
>
> Eh, the scope creation tangle is hard to follow and I'm not if there is
a
path
> that goes through here without going through one of the other places
that
> propagates the bit. :(
Acknowledged.
LGTM, too. Land it.
https://codereview.chromium.org/582703002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
