On 2014/09/10 11:49:40, caitp wrote:
On 2014/09/10 07:18:24, aperez wrote:
> On 2014/09/09 12:48:15, caitp wrote:
> > Here's a minimal one
>
> I think it would be good to use this CL to also change usage of
ToUint32(),
and
> use ToLength() instead where appropriate. You can take the places where
this
> change should be from the CL at
https://codereview.chromium.org/553623004/
Since you've already got a CL for that, it might be better to just use
yours
for
that (just removing the native implementation of ToLength)
https://codereview.chromium.org/552273002/diff/1/src/runtime.js
File src/runtime.js (right):
https://codereview.chromium.org/552273002/diff/1/src/runtime.js#newcode594
src/runtime.js:594: // ES6, draft 08-24-14, section 7.1.15
On 2014/09/10 07:29:51, rossberg wrote:
> Nit: move this next to ToInteger
Acknowledged.
https://codereview.chromium.org/552273002/diff/1/src/runtime.js#newcode597
src/runtime.js:597: if (arg < +0) return 0;
On 2014/09/10 07:29:51, rossberg wrote:
> Nit: remove the +
Acknowledged.
Is there anything else needed here? It's a pretty simple one
https://codereview.chromium.org/552273002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
