LGTM with comments.
http://codereview.chromium.org/202018/diff/1/2 File src/heap.cc (right): http://codereview.chromium.org/202018/diff/1/2#newcode3607 Line 3607: String* constructor_func = NULL; constructor_func -> constructor_name? http://codereview.chromium.org/202018/diff/1/2#newcode3608 Line 3608: int size = obj->Size(); Move size = obj->Size() to the first if part as this is where it actually counts. http://codereview.chromium.org/202018/diff/1/2#newcode3610 Line 3610: constructor_func = Heap::String_symbol(); Using obj->Size() for strings is to simple in many cases, but we can iterate over that. Also maybe we should do something special for external strings. http://codereview.chromium.org/202018/diff/1/4 File src/objects.cc (right): http://codereview.chromium.org/202018/diff/1/4#newcode1200 Line 1200: if (IsJSFunction()) return Heap::function_class_symbol(); Please place this return on a separate line and add {}'s. http://codereview.chromium.org/202018 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
