lgtm with comments
https://codereview.chromium.org/594493002/diff/20001/src/compiler/machine-operator-reducer.cc
File src/compiler/machine-operator-reducer.cc (right):
https://codereview.chromium.org/594493002/diff/20001/src/compiler/machine-operator-reducer.cc#newcode435
src/compiler/machine-operator-reducer.cc:435: case
IrOpcode::kTruncateFloat64ToFloat32: {
What about reducing ChangeFloat32ToFloat64 as well?
https://codereview.chromium.org/594493002/diff/20001/src/conversions-inl.h
File src/conversions-inl.h (right):
https://codereview.chromium.org/594493002/diff/20001/src/conversions-inl.h#newcode70
src/conversions-inl.h:70: inline float DoubleToFloat32(double x) {
I think you will need to assign the result to a volatile float local
variable, because of C++.
Ugh.
https://codereview.chromium.org/594493002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
