[v8-dev] MIPS: Make KeyedLoads from a sloppy arguments array use a handler. (issue 594563003 by [email protected])

Mon, 22 Sep 2014 07:50:19 -0700

Reviewers: danno, mvstanton, paul.l..., gergely.kis.imgtec, akos.palfi.imgtec, dusmil.imgtec, 

Description:
MIPS: Make KeyedLoads from a sloppy arguments array use a handler.

Port r24120 (eed5963)

Original commit message:
Before, a custom stub was installed.

BUG=

Please review this at https://codereview.chromium.org/594563003/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files (+0, -26 lines):
  M src/ic/mips64/ic-mips64.cc


Index: src/ic/mips64/ic-mips64.cc
diff --git a/src/ic/mips64/ic-mips64.cc b/src/ic/mips64/ic-mips64.cc
index 0ac35ffbc0e1d5923818c68980fbbfd3ebdf6e9a..a5d9fe78ff199b41867c78ec0e0efd2c44d25e75 100644 
--- a/src/ic/mips64/ic-mips64.cc
+++ b/src/ic/mips64/ic-mips64.cc
@@ -372,32 +372,6 @@ static MemOperand GenerateUnmappedArgumentsLookup(MacroAssembler* masm, 
 }


-void KeyedLoadIC::GenerateSloppyArguments(MacroAssembler* masm) {
-  // The return address is in ra.
-  Register receiver = LoadDescriptor::ReceiverRegister();
-  Register key = LoadDescriptor::NameRegister();
-  DCHECK(receiver.is(a1));
-  DCHECK(key.is(a2));
-
-  Label slow, notin;
-  MemOperand mapped_location = GenerateMappedArgumentsLookup(
-      masm, receiver, key, a0, a3, a4, &notin, &slow);
-  __ Ret(USE_DELAY_SLOT);
-  __ ld(v0, mapped_location);
-  __ bind(&notin);
-  // The unmapped lookup expects that the parameter map is in a2.
-  MemOperand unmapped_location =
-      GenerateUnmappedArgumentsLookup(masm, key, a0, a3, &slow);
-  __ ld(a0, unmapped_location);
-  __ LoadRoot(a3, Heap::kTheHoleValueRootIndex);
-  __ Branch(&slow, eq, a0, Operand(a3));
-  __ Ret(USE_DELAY_SLOT);
-  __ mov(v0, a0);
-  __ bind(&slow);
-  GenerateMiss(masm);
-}
-
-
 void KeyedStoreIC::GenerateSloppyArguments(MacroAssembler* masm) {
   Register receiver = StoreDescriptor::ReceiverRegister();
   Register key = StoreDescriptor::NameRegister();


--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group. 
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to