https://codereview.chromium.org/581223004/diff/20001/src/heap/heap.h
File src/heap/heap.h (right):

https://codereview.chromium.org/581223004/diff/20001/src/heap/heap.h#newcode1666
src/heap/heap.h:1666: Executability executable);
I don't like that method? Why can't you use AllocateRaw here?

https://codereview.chromium.org/581223004/diff/20001/src/heap/spaces.cc
File src/heap/spaces.cc (right):

https://codereview.chromium.org/581223004/diff/20001/src/heap/spaces.cc#newcode2888
src/heap/spaces.cc:2888: void
LargeObjectSpace::PrepareForDeserialization(int
large_objects_total_size) {
This method should not be part of large object space. Please move it to
heap.

https://codereview.chromium.org/581223004/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to