Reviewers: Weiliang, Sven Panne,
Message:
WL & Sven.
PTAL.
thanks
Description:
X87: Further improve deopt reason output
port r24123. R24123 does not cover all required code change in X87.
original commit message:
Further improve deopt reason output.
* Make the detailed deopt reason mandatory on x64, other platforms will
follow in separate CLs.
* Extracted and improved jump table entry sharing logic: When
--trace-deopt
is on, we get separate entries for different deopt reasons. This
enables
us to distinguish the several reasons single instructions can have.
* Don't emit superfluous jump table comments: The bailout ID is still
visible,
and the jump table entry number is not interesting (but easy to
determine
if really needed).
* Unify the internal name of the jump table member across platforms.
BUG=
Please review this at https://codereview.chromium.org/589313002/
SVN Base: https://chromium.googlesource.com/external/v8.git@bleeding_edge
Affected files (+0, -3 lines):
M src/x87/lithium-codegen-x87.cc
Index: src/x87/lithium-codegen-x87.cc
diff --git a/src/x87/lithium-codegen-x87.cc b/src/x87/lithium-codegen-x87.cc
index
40926cdc3d4ec6957b3c72bf01c2cd240fe4e1e1..ff68fd0a67296b6b0ecd31ad3e92e5492be41f5c
100644
--- a/src/x87/lithium-codegen-x87.cc
+++ b/src/x87/lithium-codegen-x87.cc
@@ -383,9 +383,6 @@ bool LCodeGen::GenerateJumpTable() {
Deoptimizer::JumpTableEntry* table_entry = &jump_table_[i];
__ bind(&table_entry->label);
Address entry = table_entry->address;
- Deoptimizer::BailoutType type = table_entry->bailout_type;
- int id = Deoptimizer::GetDeoptimizationId(isolate(), entry, type);
- DCHECK_NE(Deoptimizer::kNotDeoptimizationEntry, id);
DeoptComment(table_entry->reason);
if (table_entry->needs_frame) {
DCHECK(!info()->saves_caller_doubles());
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
