Good idea! Please see the patch set2.
Thanks
-Weiliang
https://codereview.chromium.org/591343002/diff/1/src/compiler/ia32/instruction-selector-ia32.cc
File src/compiler/ia32/instruction-selector-ia32.cc (right):
https://codereview.chromium.org/591343002/diff/1/src/compiler/ia32/instruction-selector-ia32.cc#newcode41
src/compiler/ia32/instruction-selector-ia32.cc:41: bool
CanBeBetterLeftOperand(Node* node) { return !selector()->IsUsed(node); }
On 2014/09/23 04:56:31, Benedikt Meurer wrote:
Nit: method should be const.
Done.
https://codereview.chromium.org/591343002/diff/1/src/compiler/ia32/instruction-selector-ia32.cc#newcode315
src/compiler/ia32/instruction-selector-ia32.cc:315: Emit(kIA32Imul,
g.DefineSameAsFirst(node), g.UseRegister(left),
On 2014/09/23 04:57:37, Benedikt Meurer wrote:
There should be no need to use DefineSameAsFirst with imul.
My thought here is that three operand imul requires an imm input. If
there is no imm input, we can only use the two-operands/single-operand
imul. That is why I still use DefineSameAsFirst here.
https://codereview.chromium.org/591343002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
