Reviewers: Weiliang, Sven Panne,
Message:
weiliang & Sven.
PTAL.
thanks.
Description:
X87: Removed superfluous deopt for ROR on ia32.
port r24133. On X87 this check should be unnecessary too.
original commit message:
Removed superfluous deopt for ROR on ia32.
We only synthesize a ROR when we have an expression with a toplevel
'|', which returns a signed value by definition, so deopting on
negative values is not needed. ia32 was the only platform where this
was done, all other didn't have the check.
BUG=
Please review this at https://codereview.chromium.org/589383003/
SVN Base: https://chromium.googlesource.com/external/v8.git@bleeding_edge
Affected files (+0, -4 lines):
M src/x87/lithium-codegen-x87.cc
Index: src/x87/lithium-codegen-x87.cc
diff --git a/src/x87/lithium-codegen-x87.cc b/src/x87/lithium-codegen-x87.cc
index
ff68fd0a67296b6b0ecd31ad3e92e5492be41f5c..8e280a24438b6bd667a558b63243b829135537a8
100644
--- a/src/x87/lithium-codegen-x87.cc
+++ b/src/x87/lithium-codegen-x87.cc
@@ -1908,10 +1908,6 @@ void LCodeGen::DoShiftI(LShiftI* instr) {
switch (instr->op()) {
case Token::ROR:
__ ror_cl(ToRegister(left));
- if (instr->can_deopt()) {
- __ test(ToRegister(left), ToRegister(left));
- DeoptimizeIf(sign, instr);
- }
break;
case Token::SAR:
__ sar_cl(ToRegister(left));
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
