Revision: 24160
Author: [email protected]
Date: Wed Sep 24 02:37:53 2014 UTC
Log: X87: Removed superfluous deopt for ROR on ia32.
port r24133. On X87 this check should be unnecessary too.
original commit message:
Removed superfluous deopt for ROR on ia32.
We only synthesize a ROR when we have an expression with a toplevel
'|', which returns a signed value by definition, so deopting on
negative values is not needed. ia32 was the only platform where this
was done, all other didn't have the check.
BUG=
[email protected]
Review URL: https://codereview.chromium.org/589383003
Patch from Chunyang Dai <[email protected]>.
https://code.google.com/p/v8/source/detail?r=24160
Modified:
/branches/bleeding_edge/src/x87/lithium-codegen-x87.cc
=======================================
--- /branches/bleeding_edge/src/x87/lithium-codegen-x87.cc Tue Sep 23
03:55:35 2014 UTC
+++ /branches/bleeding_edge/src/x87/lithium-codegen-x87.cc Wed Sep 24
02:37:53 2014 UTC
@@ -1908,10 +1908,6 @@
switch (instr->op()) {
case Token::ROR:
__ ror_cl(ToRegister(left));
- if (instr->can_deopt()) {
- __ test(ToRegister(left), ToRegister(left));
- DeoptimizeIf(sign, instr);
- }
break;
case Token::SAR:
__ sar_cl(ToRegister(left));
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
