On 2014/09/24 06:00:19, Sven Panne wrote:
https://codereview.chromium.org/596783002/diff/1/src/lithium.cc
File src/lithium.cc (right):
https://codereview.chromium.org/596783002/diff/1/src/lithium.cc#newcode7
src/lithium.cc:7: #include "src/bailout-reason.h"
On 2014/09/23 16:21:00, Jakob wrote:
> This shouldn't be necessary as lithium.h includes it already.
IWYU...
As discussed offline with Yang, Jakob's comment was OK, because we are in
FOO.cc
and FOO.h already includes it. I was confused, because the include of FOO.h
within FOO.cc was not at the top where it should be (to be done).
cpplint actually tries to check the include order (FOO.h, c system, c++
system,
other), but it obviously fails to enforce that FOO.h must come first.
https://codereview.chromium.org/596783002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
