On 2014/09/24 06:07:40, Dmitry Lomov (chromium) wrote:
https://codereview.chromium.org/598603002/diff/1/src/messages.js
File src/messages.js (right):
https://codereview.chromium.org/598603002/diff/1/src/messages.js#newcode1128
src/messages.js:1128: holder = %GetPrototype(holder);
On 2014/09/23 18:31:20, arv wrote:
> Why are we using own private symbols here? It is clear that we want
non own
> here.
I just wanted to remove all non-own symbols from V8 code (in a built-ins,
all
private symbols should be own, so that is is clear that GET_PRIVATE never
walks
the proto chain).
I also wanted to kill private non-own in general, but then realized it is
useful
for the API.
Maybe I can continue using non-own here. I have no strong opinion.
I thought about it further - since the way we walk the prototype chain and
install properties here is quite non-standard, we should keep the symbol
private
own.
https://codereview.chromium.org/598603002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
