Addressed comments. PTAL.
https://codereview.chromium.org/595963002/diff/1/src/compiler/js-builtin-reducer-unittest.cc
File src/compiler/js-builtin-reducer-unittest.cc (right):
https://codereview.chromium.org/595963002/diff/1/src/compiler/js-builtin-reducer-unittest.cc#newcode76
src/compiler/js-builtin-reducer-unittest.cc:76:
EXPECT_TRUE(r.Changed());
On 2014/09/24 06:34:43, Benedikt Meurer wrote:
Nit: use ASSERT_TRUE, doesn't make sense to do the EXPECT_THAT below
if it
didn't change.
Done, here and at all occurrences below.
https://codereview.chromium.org/595963002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
