Reviewers: Weiliang, Sven Panne,
Message:
weiliang.
PTAL.
thanks
Description:
X87: fixed branch distances.
port r24151.
original commit message:
Forgot a few kNear occurences, only happens with --deopt-every-n-times.
Death to manual jump distance calculation! :-P
BUG=
Please review this at https://codereview.chromium.org/595263002/
SVN Base: https://chromium.googlesource.com/external/v8.git@bleeding_edge
Affected files (+6, -5 lines):
M src/x87/lithium-codegen-x87.cc
Index: src/x87/lithium-codegen-x87.cc
diff --git a/src/x87/lithium-codegen-x87.cc b/src/x87/lithium-codegen-x87.cc
index
4f79f84cbbac8e778dd764fa5c61c11f65f425cb..95a12b3ca93cf6e1b63e3804993372afe2ce043d
100644
--- a/src/x87/lithium-codegen-x87.cc
+++ b/src/x87/lithium-codegen-x87.cc
@@ -5302,9 +5302,10 @@ void LCodeGen::DoDoubleToI(LDoubleToI* instr) {
Label lost_precision, is_nan, minus_zero, done;
X87Register input_reg = ToX87Register(input);
X87Fxch(input_reg);
+ Label::Distance dist = DeoptEveryNTimes() ? Label::kFar : Label::kNear;
__ X87TOSToI(result_reg, instr->hydrogen()->GetMinusZeroMode(),
- &lost_precision, &is_nan, &minus_zero, Label::kNear);
- __ jmp(&done, Label::kNear);
+ &lost_precision, &is_nan, &minus_zero, dist);
+ __ jmp(&done, dist);
__ bind(&lost_precision);
DeoptimizeIf(no_condition, instr, "lost precision");
__ bind(&is_nan);
@@ -5326,10 +5327,10 @@ void LCodeGen::DoDoubleToSmi(LDoubleToSmi* instr) {
Label lost_precision, is_nan, minus_zero, done;
X87Register input_reg = ToX87Register(input);
X87Fxch(input_reg);
+ Label::Distance dist = DeoptEveryNTimes() ? Label::kFar : Label::kNear;
__ X87TOSToI(result_reg, instr->hydrogen()->GetMinusZeroMode(),
- &lost_precision, &is_nan, &minus_zero,
- DeoptEveryNTimes() ? Label::kFar : Label::kNear);
- __ jmp(&done, Label::kNear);
+ &lost_precision, &is_nan, &minus_zero, dist);
+ __ jmp(&done, dist);
__ bind(&lost_precision);
DeoptimizeIf(no_condition, instr, "lost precision");
__ bind(&is_nan);
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
