Looking good.
https://codereview.chromium.org/602563002/diff/1/src/compiler/generic-node.h
File src/compiler/generic-node.h (right):
https://codereview.chromium.org/602563002/diff/1/src/compiler/generic-node.h#newcode44
src/compiler/generic-node.h:44: inline void RemoveInput(int index);
There is a copy of this method in js-generic-lowering.cc, now that you
added this one, please use it in JSGenericLowering::ReplaceWithCompareIC
as well. Just look for TODO(jarin) there.
Also, let's add a unit test for this to test-node.cc as well (just one
unit test would be good enough for me).
https://codereview.chromium.org/602563002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
