On 2014/09/25 08:06:03, Igor Sheludko wrote:
https://codereview.chromium.org/593073002/diff/20001/src/ia32/full-codegen-ia32.cc
File src/ia32/full-codegen-ia32.cc (right):
https://codereview.chromium.org/593073002/diff/20001/src/ia32/full-codegen-ia32.cc#newcode1845
src/ia32/full-codegen-ia32.cc:1845: break;
I'm afraid that the second pair of receiver-home object is not necessary
in
case
of non-compound assignment.
Thanks, good catch, actually found it myself as well.
The proper tests should always include the use of assignment expression
value,
then the bug manifests.
https://codereview.chromium.org/593073002/diff/20001/test/mjsunit/harmony/super.js
File test/mjsunit/harmony/super.js (right):
https://codereview.chromium.org/593073002/diff/20001/test/mjsunit/harmony/super.js#newcode96
test/mjsunit/harmony/super.js:96: Derived.prototype.testSetter =
function() {
Suggestion: test the strict mode too (and same for getter tests).
https://codereview.chromium.org/593073002/diff/20001/test/mjsunit/harmony/super.js#newcode122
test/mjsunit/harmony/super.js:122: assertThrows(function() { d.mStrict();
},
ReferenceError);
Suggestion: use different instances of Derived for sloppy and strict
tests and
check that after the assignment the property appears neither in Base nor
in d.
https://codereview.chromium.org/593073002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
