On 2014/09/25 14:39:12, aandrey wrote:
On 2014/09/25 14:34:02, Yang wrote:
> Would it make sense to have v8::Function::IsGenerator() instead of
> v8::Value::IsGeneratorFunction()?
>
> Adding Ulan because this is an API change.
It's your call.
To me, it's clearer to have the IsGeneratorFunction/IsGeneratorObject pair
than
IsGenerator/IsGeneratorObject. I'd guess the latter would make me think
which
is
what.
Let's keep it this way. The spec does not say that generator functions are
functions, so let's not expose this implementation detail to the API. LGTM.
https://codereview.chromium.org/608503002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
