Reviewers: Benedikt Meurer,
Description:
Drop deprecated method for backing store from AccessBuilder.
[email protected]
TEST=cctest/test-simplified-lowering/RunLoadStoreArrayBuffer
Please review this at https://codereview.chromium.org/614703002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+1, -11 lines):
M src/compiler/access-builder.h
M src/compiler/access-builder.cc
M test/cctest/compiler/test-simplified-lowering.cc
Index: src/compiler/access-builder.cc
diff --git a/src/compiler/access-builder.cc b/src/compiler/access-builder.cc
index
ac9cfa858b421bbb034c5c1831439c00c320139c..749c04a0c5b1470a37e49513555fa7c44df586d2
100644
--- a/src/compiler/access-builder.cc
+++ b/src/compiler/access-builder.cc
@@ -58,13 +58,6 @@ ElementAccess AccessBuilder::ForFixedArrayElement() {
// static
-ElementAccess AccessBuilder::ForBackingStoreElement(MachineType rep) {
- return {kUntaggedBase, kNonHeapObjectHeaderSize - kHeapObjectTag,
Type::Any(),
- rep};
-}
-
-
-// static
ElementAccess AccessBuilder::ForTypedArrayElement(ExternalArrayType type,
bool is_external) {
BaseTaggedness taggedness = is_external ? kUntaggedBase : kTaggedBase;
Index: src/compiler/access-builder.h
diff --git a/src/compiler/access-builder.h b/src/compiler/access-builder.h
index
7d0bda1398e7aaec383913b1096f5a22923aab3d..72dd0234aa071eb8030145c3dcc244d0b1a59d99
100644
--- a/src/compiler/access-builder.h
+++ b/src/compiler/access-builder.h
@@ -37,9 +37,6 @@ class AccessBuilder FINAL : public AllStatic {
// Provides access to FixedArray elements.
static ElementAccess ForFixedArrayElement();
- // TODO(mstarzinger): Raw access only for testing, drop me.
- static ElementAccess ForBackingStoreElement(MachineType rep);
-
// Provides access to Fixed{type}TypedArray and External{type}Array
elements.
static ElementAccess ForTypedArrayElement(ExternalArrayType type,
bool is_external);
Index: test/cctest/compiler/test-simplified-lowering.cc
diff --git a/test/cctest/compiler/test-simplified-lowering.cc
b/test/cctest/compiler/test-simplified-lowering.cc
index
e67df9bfd8cabe4c7a413d31648c165371639b0a..bafa2d88f42ddc976cf9c4904c11895f612a9fa2
100644
--- a/test/cctest/compiler/test-simplified-lowering.cc
+++ b/test/cctest/compiler/test-simplified-lowering.cc
@@ -235,7 +235,7 @@ TEST(RunLoadStoreArrayBuffer) {
const int index = 12;
const int array_length = 2 * index;
ElementAccess buffer_access =
- AccessBuilder::ForBackingStoreElement(kMachInt8);
+ AccessBuilder::ForTypedArrayElement(v8::kExternalInt8Array, true);
Node* backing_store = t.LoadField(
AccessBuilder::ForJSArrayBufferBackingStore(), t.Parameter(0));
Node* load =
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
