Revision: 24282
Author: [email protected]
Date: Mon Sep 29 11:35:01 2014 UTC
Log: Drop deprecated method for backing store from AccessBuilder.
[email protected]
TEST=cctest/test-simplified-lowering/RunLoadStoreArrayBuffer
Review URL: https://codereview.chromium.org/614703002
https://code.google.com/p/v8/source/detail?r=24282
Modified:
/branches/bleeding_edge/src/compiler/access-builder.cc
/branches/bleeding_edge/src/compiler/access-builder.h
/branches/bleeding_edge/test/cctest/compiler/test-simplified-lowering.cc
=======================================
--- /branches/bleeding_edge/src/compiler/access-builder.cc Wed Sep 10
09:48:03 2014 UTC
+++ /branches/bleeding_edge/src/compiler/access-builder.cc Mon Sep 29
11:35:01 2014 UTC
@@ -55,13 +55,6 @@
ElementAccess AccessBuilder::ForFixedArrayElement() {
return {kTaggedBase, FixedArray::kHeaderSize, Type::Any(),
kMachAnyTagged};
}
-
-
-// static
-ElementAccess AccessBuilder::ForBackingStoreElement(MachineType rep) {
- return {kUntaggedBase, kNonHeapObjectHeaderSize - kHeapObjectTag,
Type::Any(),
- rep};
-}
// static
=======================================
--- /branches/bleeding_edge/src/compiler/access-builder.h Wed Sep 10
09:48:03 2014 UTC
+++ /branches/bleeding_edge/src/compiler/access-builder.h Mon Sep 29
11:35:01 2014 UTC
@@ -37,9 +37,6 @@
// Provides access to FixedArray elements.
static ElementAccess ForFixedArrayElement();
- // TODO(mstarzinger): Raw access only for testing, drop me.
- static ElementAccess ForBackingStoreElement(MachineType rep);
-
// Provides access to Fixed{type}TypedArray and External{type}Array
elements.
static ElementAccess ForTypedArrayElement(ExternalArrayType type,
bool is_external);
=======================================
---
/branches/bleeding_edge/test/cctest/compiler/test-simplified-lowering.cc
Wed Sep 24 11:08:35 2014 UTC
+++
/branches/bleeding_edge/test/cctest/compiler/test-simplified-lowering.cc
Mon Sep 29 11:35:01 2014 UTC
@@ -235,7 +235,7 @@
const int index = 12;
const int array_length = 2 * index;
ElementAccess buffer_access =
- AccessBuilder::ForBackingStoreElement(kMachInt8);
+ AccessBuilder::ForTypedArrayElement(v8::kExternalInt8Array, true);
Node* backing_store = t.LoadField(
AccessBuilder::ForJSArrayBufferBackingStore(), t.Parameter(0));
Node* load =
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
