Looking good modulo one comment which I feel pretty strongly about, and
that we
already talked offline about. I think we should avoid making construction
of the
parameter-structures explicit.
https://codereview.chromium.org/613683002/diff/20001/src/compiler/ast-graph-builder.cc
File src/compiler/ast-graph-builder.cc (right):
https://codereview.chromium.org/613683002/diff/20001/src/compiler/ast-graph-builder.cc#newcode79
src/compiler/ast-graph-builder.cc:79:
CallRuntimeParameters(Runtime::kTraceEnter, 0)));
I think we should continue to let the factory method materialize the
CallRuntimeParameters (and friends) for us instead of doing it
explicitly. Otherwise readability of these call-sites suffers.
https://codereview.chromium.org/613683002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
