https://codereview.chromium.org/610323004/diff/1/src/compiler/arm64/instruction-selector-arm64-unittest.cc
File src/compiler/arm64/instruction-selector-arm64-unittest.cc (right):
https://codereview.chromium.org/610323004/diff/1/src/compiler/arm64/instruction-selector-arm64-unittest.cc#newcode373
src/compiler/arm64/instruction-selector-arm64-unittest.cc:373: if
(strstr(dpi.mi.constructor_name, "Add") != NULL) {
See comment below.
https://codereview.chromium.org/610323004/diff/1/src/compiler/arm64/instruction-selector-arm64-unittest.cc#newcode398
src/compiler/arm64/instruction-selector-arm64-unittest.cc:398: if
(strstr(dpi.mi.constructor_name, "Add") != NULL) {
Please split the test case instead of filtering, i.e. add new tests that
run only for add instructions like InstructionSelectorAddTest.
https://codereview.chromium.org/610323004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
