https://codereview.chromium.org/615483003/diff/20001/src/compiler/node-matchers.h
File src/compiler/node-matchers.h (right):
https://codereview.chromium.org/615483003/diff/20001/src/compiler/node-matchers.h#newcode215
src/compiler/node-matchers.h:215: bool Matches() { return left_ != NULL;
}
Nit: const
https://codereview.chromium.org/615483003/diff/20001/src/compiler/node-matchers.h#newcode216
src/compiler/node-matchers.h:216: int Power() {
Nit: const
https://codereview.chromium.org/615483003/diff/20001/src/compiler/node-matchers.h#newcode220
src/compiler/node-matchers.h:220: Node* Left() {
Nit: const
https://codereview.chromium.org/615483003/diff/20001/src/compiler/node-matchers.h#newcode225
src/compiler/node-matchers.h:225: int32_t Displacement() {
Nit: const
https://codereview.chromium.org/615483003/diff/20001/src/compiler/node-matchers.h#newcode231
src/compiler/node-matchers.h:231: void Match();
Hm, those Match method(s) could be inlined into the constructor, and the
constructor should reside in the .cc file.
https://codereview.chromium.org/615483003/diff/20001/src/compiler/x64/instruction-codes-x64.h
File src/compiler/x64/instruction-codes-x64.h (right):
https://codereview.chromium.org/615483003/diff/20001/src/compiler/x64/instruction-codes-x64.h#newcode97
src/compiler/x64/instruction-codes-x64.h:97: V(MX1) /* [%r1 + %r1*1
] */ \
Why do we need these additional modes? MXn is just a special case of
MRn, so it's basically redundant or am I missing something?
https://codereview.chromium.org/615483003/diff/20001/src/compiler/x64/instruction-selector-x64-unittest.cc
File src/compiler/x64/instruction-selector-x64-unittest.cc (right):
https://codereview.chromium.org/615483003/diff/20001/src/compiler/x64/instruction-selector-x64-unittest.cc#newcode312
src/compiler/x64/instruction-selector-x64-unittest.cc:312: static const
MultParam kMultParams[] = {{-1, false, kMode_None},
No need for static here, it's already inside an anonymous namespace.
https://codereview.chromium.org/615483003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
