https://codereview.chromium.org/622523004/diff/1/src/runtime/runtime-classes.cc
File src/runtime/runtime-classes.cc (right):
https://codereview.chromium.org/622523004/diff/1/src/runtime/runtime-classes.cc#newcode86
src/runtime/runtime-classes.cc:86: if (!key->IsName()) {
How can this happen?
Maybe change to
CONVERT_ARG_HANDLE_CHECKED(Name, name, 2);
Can you add tests for these cases?
https://codereview.chromium.org/622523004/diff/1/src/runtime/runtime-classes.cc#newcode91
src/runtime/runtime-classes.cc:91: if (name->AsArrayIndex(&index)) {
Same here. When does this happen?
https://codereview.chromium.org/622523004/diff/1/src/runtime/runtime-classes.cc#newcode103
src/runtime/runtime-classes.cc:103: CONVERT_ARG_HANDLE_CHECKED(Name,
name, 2);
Is this backwards? I thought keyed mean `super[key]` so key can be
anything.
https://codereview.chromium.org/622523004/diff/1/test/mjsunit/harmony/super.js
File test/mjsunit/harmony/super.js (right):
https://codereview.chromium.org/622523004/diff/1/test/mjsunit/harmony/super.js#newcode46
test/mjsunit/harmony/super.js:46: this[derivedDataProperty] = "xxx";
consistency
https://codereview.chromium.org/622523004/diff/1/test/mjsunit/harmony/super.js#newcode74
test/mjsunit/harmony/super.js:74:
Can you add tests that uses numeric keys?
Can you add test that uses an object that has a toString and make sure
that it is only called once.
And a test that throws in toString
https://codereview.chromium.org/622523004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
