https://codereview.chromium.org/615813004/diff/20001/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (right):
https://codereview.chromium.org/615813004/diff/20001/test/cctest/test-parsing.cc#newcode3858
test/cctest/test-parsing.cc:3858: "static 'prot\u006ftype'() {}",
Can you also add:
"static 'prototype'() {}",
...
while you are here?
https://codereview.chromium.org/615813004/diff/20001/test/cctest/test-parsing.cc#newcode3884
test/cctest/test-parsing.cc:3884: "*'c\u006fnstructor'() {}",
same
https://codereview.chromium.org/615813004/diff/40001/src/scanner.h
File src/scanner.h (right):
https://codereview.chromium.org/615813004/diff/40001/src/scanner.h#newcode387
src/scanner.h:387: bool LiteralMatches(const char* data, int length,
bool allow_escapes) {
You can use default params here:
bool allow_escapes = true
https://codereview.chromium.org/615813004/diff/40001/src/scanner.h#newcode401
src/scanner.h:401: inline bool LiteralMatches(const char* data, int
length) {
Then this can be removed
https://codereview.chromium.org/615813004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
