On 2014/10/01 14:26:22, mvstanton wrote:
Nice solution. LGTM, just one comment about a nice to have in the test.
https://codereview.chromium.org/623453003/diff/1/test/cctest/test-serialize.cc
File test/cctest/test-serialize.cc (right):
https://codereview.chromium.org/623453003/diff/1/test/cctest/test-serialize.cc#newcode954
test/cctest/test-serialize.cc:954:
two_byte_string->MakeExternal(&two_byte_resource);
I like these tests. Nit: Is it possible to check that the external string
for
"one_byte" and "two_byte" do not exist in the context that you deserialize
into?
That would verify that you don't create an external string, but just an
internalized string. I guess you'd have to make a new handle scope for
that?
As talked about offline, there is no test in place to check the string type
after serialization, and I don't think it's necessary.
https://codereview.chromium.org/623453003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
