Revision: 24392
Author: [email protected]
Date: Thu Oct 2 10:52:12 2014 UTC
Log: Drop some unused code
Bonus: fix bitrot in (disabled) Hydrogen-BCH
[email protected]
Review URL: https://codereview.chromium.org/623513002
https://code.google.com/p/v8/source/detail?r=24392
Modified:
/branches/bleeding_edge/src/accessors.cc
/branches/bleeding_edge/src/accessors.h
/branches/bleeding_edge/src/hydrogen-bch.cc
/branches/bleeding_edge/src/hydrogen-instructions.cc
/branches/bleeding_edge/src/hydrogen.cc
/branches/bleeding_edge/src/hydrogen.h
/branches/bleeding_edge/src/type-info.cc
/branches/bleeding_edge/src/type-info.h
/branches/bleeding_edge/src/utils.h
=======================================
--- /branches/bleeding_edge/src/accessors.cc Wed Sep 10 12:38:12 2014 UTC
+++ /branches/bleeding_edge/src/accessors.cc Thu Oct 2 10:52:12 2014 UTC
@@ -54,17 +54,6 @@
info->set_data(accessor->data());
return info;
}
-
-
-template <class C>
-static C* FindInstanceOf(Isolate* isolate, Object* obj) {
- for (PrototypeIterator iter(isolate, obj,
- PrototypeIterator::START_AT_RECEIVER);
- !iter.IsAtEnd(); iter.Advance()) {
- if (Is<C>(iter.GetCurrent())) return C::cast(iter.GetCurrent());
- }
- return NULL;
-}
static V8_INLINE bool CheckForName(Handle<Name> name,
@@ -914,11 +903,6 @@
return function;
}
-
-
-Handle<Object> Accessors::FunctionGetPrototype(Handle<JSFunction>
function) {
- return GetFunctionPrototype(function->GetIsolate(), function);
-}
Handle<Object> Accessors::FunctionSetPrototype(Handle<JSFunction> function,
=======================================
--- /branches/bleeding_edge/src/accessors.h Mon Aug 25 09:12:22 2014 UTC
+++ /branches/bleeding_edge/src/accessors.h Thu Oct 2 10:52:12 2014 UTC
@@ -68,7 +68,6 @@
// Accessor functions called directly from the runtime system.
static Handle<Object> FunctionSetPrototype(Handle<JSFunction> object,
Handle<Object> value);
- static Handle<Object> FunctionGetPrototype(Handle<JSFunction> object);
static Handle<Object> FunctionGetArguments(Handle<JSFunction> object);
// Accessor infos.
=======================================
--- /branches/bleeding_edge/src/hydrogen-bch.cc Mon Aug 4 11:34:54 2014 UTC
+++ /branches/bleeding_edge/src/hydrogen-bch.cc Thu Oct 2 10:52:12 2014 UTC
@@ -237,14 +237,13 @@
// constant limit we will use that instead of the induction limit.
bool has_upper_constant_limit = true;
int32_t upper_constant_limit =
- check != NULL && check->HasUpperLimit() ? check->upper_limit() : 0;
+ check->HasUpperLimit() ? check->upper_limit() : 0;
for (InductionVariableData::InductionVariableCheck* current_check =
check;
current_check != NULL;
current_check = current_check->next()) {
has_upper_constant_limit =
- has_upper_constant_limit &&
- check->HasUpperLimit() &&
- check->upper_limit() == upper_constant_limit;
+ has_upper_constant_limit && current_check->HasUpperLimit() &&
+ current_check->upper_limit() == upper_constant_limit;
counters()->bounds_checks_eliminated()->Increment();
current_check->check()->set_skip_check();
}
=======================================
--- /branches/bleeding_edge/src/hydrogen-instructions.cc Wed Oct 1
11:53:29 2014 UTC
+++ /branches/bleeding_edge/src/hydrogen-instructions.cc Thu Oct 2
10:52:12 2014 UTC
@@ -2211,7 +2211,7 @@
*/
int32_t InductionVariableData::ComputeIncrement(HPhi* phi,
HValue* phi_operand) {
- if (!phi_operand->representation().IsInteger32()) return 0;
+ if (!phi_operand->representation().IsSmiOrInteger32()) return 0;
if (phi_operand->IsAdd()) {
HAdd* operation = HAdd::cast(phi_operand);
=======================================
--- /branches/bleeding_edge/src/hydrogen.cc Wed Oct 1 13:17:34 2014 UTC
+++ /branches/bleeding_edge/src/hydrogen.cc Thu Oct 2 10:52:12 2014 UTC
@@ -4,15 +4,12 @@
#include "src/hydrogen.h"
-#include <algorithm>
#include <sstream>
#include "src/v8.h"
#include "src/allocation-site-scopes.h"
-#include "src/codegen.h"
#include "src/full-codegen.h"
-#include "src/hashmap.h"
#include "src/hydrogen-bce.h"
#include "src/hydrogen-bch.h"
#include "src/hydrogen-canonicalize.h"
@@ -43,7 +40,6 @@
#include "src/parser.h"
#include "src/runtime/runtime.h"
#include "src/scopeinfo.h"
-#include "src/scopes.h"
#include "src/typing.h"
#if V8_TARGET_ARCH_IA32
@@ -2902,10 +2898,6 @@
BuildFillElementsWithHole(to_elements, to_elements_kind,
length, NULL);
}
-
- if (capacity == NULL) {
- capacity = AddLoadFixedArrayLength(to_elements);
- }
LoopBuilder builder(this, context(), LoopBuilder::kPostDecrement);
@@ -6313,7 +6305,7 @@
HControlInstruction* smi_check = NULL;
handled_string = false;
- for (int i = 0; i < types->length() && count < kMaxLoadPolymorphism;
++i) {
+ for (i = 0; i < types->length() && count < kMaxLoadPolymorphism; ++i) {
PropertyAccessInfo info(this, access_type, ToType(types->at(i)), name);
if (info.type()->Is(Type::String())) {
if (handled_string) continue;
@@ -6391,7 +6383,7 @@
// know about and do not want to handle ones we've never seen. Otherwise
// use a generic IC.
if (count == types->length() && FLAG_deoptimize_uncommon_cases) {
- FinishExitWithHardDeoptimization("Uknown map in polymorphic access");
+ FinishExitWithHardDeoptimization("Unknown map in polymorphic access");
} else {
HInstruction* instr = BuildNamedGeneric(access_type, expr, object,
name,
value);
@@ -9111,7 +9103,6 @@
LookupIterator::OWN_SKIP_INTERCEPTOR);
GlobalPropertyAccess type = LookupGlobalProperty(var, &it, LOAD);
if (type == kUseCell) {
- Handle<GlobalObject> global(current_info()->global_object());
known_global_function = expr->ComputeGlobalTarget(global, &it);
}
if (known_global_function) {
=======================================
--- /branches/bleeding_edge/src/hydrogen.h Tue Sep 30 10:29:32 2014 UTC
+++ /branches/bleeding_edge/src/hydrogen.h Thu Oct 2 10:52:12 2014 UTC
@@ -315,7 +315,6 @@
HEnvironment* start_environment() const { return start_environment_; }
void FinalizeUniqueness();
- bool ProcessArgumentsObject();
void OrderBlocks();
void AssignDominators();
void RestoreActualValues();
@@ -478,8 +477,6 @@
Phase phase(this);
phase.Run();
}
-
- void EliminateRedundantBoundsChecksUsingInductionVariables();
Isolate* isolate_;
int next_block_id_;
@@ -2204,7 +2201,6 @@
void VisitLogicalExpression(BinaryOperation* expr);
void VisitArithmeticExpression(BinaryOperation* expr);
- bool PreProcessOsrEntry(IterationStatement* statement);
void VisitLoopBody(IterationStatement* stmt,
HBasicBlock* loop_entry);
=======================================
--- /branches/bleeding_edge/src/type-info.cc Thu Sep 18 12:31:31 2014 UTC
+++ /branches/bleeding_edge/src/type-info.cc Thu Oct 2 10:52:12 2014 UTC
@@ -9,11 +9,8 @@
#include "src/compiler.h"
#include "src/ic/ic.h"
#include "src/ic/stub-cache.h"
-#include "src/macro-assembler.h"
#include "src/type-info.h"
-#include "src/objects-inl.h"
-
namespace v8 {
namespace internal {
@@ -79,17 +76,6 @@
Handle<Code> code = Handle<Code>::cast(maybe_code);
return code->ic_state() == UNINITIALIZED;
}
-
-
-bool TypeFeedbackOracle::StoreIsKeyedPolymorphic(TypeFeedbackId ast_id) {
- Handle<Object> maybe_code = GetInfo(ast_id);
- if (maybe_code->IsCode()) {
- Handle<Code> code = Handle<Code>::cast(maybe_code);
- return code->is_keyed_store_stub() &&
- code->ic_state() == POLYMORPHIC;
- }
- return false;
-}
bool TypeFeedbackOracle::CallIsMonomorphic(int slot) {
=======================================
--- /branches/bleeding_edge/src/type-info.h Thu Sep 18 09:59:53 2014 UTC
+++ /branches/bleeding_edge/src/type-info.h Thu Oct 2 10:52:12 2014 UTC
@@ -25,7 +25,6 @@
bool LoadIsUninitialized(TypeFeedbackId id);
bool StoreIsUninitialized(TypeFeedbackId id);
- bool StoreIsKeyedPolymorphic(TypeFeedbackId id);
bool CallIsMonomorphic(int slot);
bool CallIsMonomorphic(TypeFeedbackId aid);
bool KeyedArrayCallIsHoley(TypeFeedbackId id);
=======================================
--- /branches/bleeding_edge/src/utils.h Mon Sep 22 14:16:38 2014 UTC
+++ /branches/bleeding_edge/src/utils.h Thu Oct 2 10:52:12 2014 UTC
@@ -61,7 +61,6 @@
}
DCHECK_EQ(1 << bits, original_x);
return bits;
- return 0;
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
