On 2014/10/03 07:50:23, Denis Pravdin wrote:
On 2014/10/02 11:52:37, yurys wrote:
> A revert of this CL (patchset #3 id:40001) has been created in
> https://codereview.chromium.org/624443005/ by mailto:[email protected].
>
> The reason for reverting is: It broke layout test
> fast/events/window-onerror-02.html:
>
>
http://build.chromium.org/p/client.v8/builders/V8-Blink%20Linux%2064%20%28dbg%29/builds/652.
Yurys,
Which steps are expected in this case from my end? I should triage why the
test
fails and fix it. Once it's done that a new patch should be uploaded for
review.
Right?
Correct. Looks like your patch regresses behavior of window.onerror so this
needs to be fixed before landing. You can reproduce it by checking out and
building Blink, instructions for running layout tests can be found at
http://www.chromium.org/developers/testing/webkit-layout-tests#TOC-Running-the-Tests
Alternatively if you don't want to build Blink you can try to come up with a
reduced test case that could be executed with bare V8. The error event
passed
into window.onerror is constructed based on the data passed into message
listener added to v8 via v8::V8::AddMessageListener();. So you can probably
add
a new test to test/cctest/ that would execute script similar to the one in
fast/events/window-onerror-02.htm and check that the error column passed
into
the message listener is correct.
Thanks,
Denis
https://codereview.chromium.org/616963005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
