Done as suggested. Thanks!
https://codereview.chromium.org/614713002/diff/80001/src/compiler/code-generator.cc
File src/compiler/code-generator.cc (right):
https://codereview.chromium.org/614713002/diff/80001/src/compiler/code-generator.cc#newcode415
src/compiler/code-generator.cc:415: DCHECK_EQ(kRepFloat64, type &
kRepMask);
On 2014/10/06 08:56:02, titzer wrote:
You probably need to account for float32 here as well.
Done.
https://codereview.chromium.org/614713002/diff/80001/src/compiler/code-generator.cc#newcode430
src/compiler/code-generator.cc:430: DCHECK_EQ(kRepFloat64, type &
kRepMask);
On 2014/10/06 08:56:01, titzer wrote:
And here.
Done.
https://codereview.chromium.org/614713002/diff/80001/src/compiler/instruction.h
File src/compiler/instruction.h (right):
https://codereview.chromium.org/614713002/diff/80001/src/compiler/instruction.h#newcode736
src/compiler/instruction.h:736: void SetTypes(ZoneVector<MachineType>*
types);
On 2014/10/06 08:54:11, titzer wrote:
The types vector only describes this frame state's types, correct? If
so, its
size should be determinable from the parameters, locals, and stack
count. Can we
allocate the vector here and offer peek/poke methods into it?
Done.
https://codereview.chromium.org/614713002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
