Revision: 24409
Author: [email protected]
Date: Mon Oct 6 11:14:50 2014 UTC
Log: Revert Add a use counter for Intl.v8BreakIterator
https://codereview.chromium.org/619913002/
This is due to breakage on the ASAN memory leak bot, possibly due to
pre-existing leaks in v8BreakIterator().
[email protected]
BUG=
Review URL: https://codereview.chromium.org/636493004
https://code.google.com/p/v8/source/detail?r=24409
Modified:
/branches/bleeding_edge/include/v8.h
/branches/bleeding_edge/src/i18n.cc
/branches/bleeding_edge/test/cctest/test-strings.cc
=======================================
--- /branches/bleeding_edge/include/v8.h Fri Oct 3 10:29:12 2014 UTC
+++ /branches/bleeding_edge/include/v8.h Mon Oct 6 11:14:50 2014 UTC
@@ -4528,7 +4528,6 @@
*/
enum UseCounterFeature {
kUseAsm = 0,
- kBreakIterator = 1,
kUseCounterFeatureCount // This enum value must be last.
};
=======================================
--- /branches/bleeding_edge/src/i18n.cc Fri Oct 3 10:29:12 2014 UTC
+++ /branches/bleeding_edge/src/i18n.cc Mon Oct 6 11:14:50 2014 UTC
@@ -630,8 +630,6 @@
delete break_iterator;
return NULL;
}
-
- isolate->CountUsage(v8::Isolate::UseCounterFeature::kBreakIterator);
return break_iterator;
}
=======================================
--- /branches/bleeding_edge/test/cctest/test-strings.cc Fri Oct 3 10:29:12
2014 UTC
+++ /branches/bleeding_edge/test/cctest/test-strings.cc Mon Oct 6 11:14:50
2014 UTC
@@ -1290,35 +1290,6 @@
CompileRun("var slice = long.slice(1, 15);");
CheckException("%_SubString(slice, 0, 17);");
}
-
-
-namespace {
-
-int* global_use_counts = NULL;
-
-void MockUseCounterCallback(v8::Isolate* isolate,
- v8::Isolate::UseCounterFeature feature) {
- ++global_use_counts[feature];
-}
-}
-
-
-TEST(CountBreakIterator) {
- CcTest::InitializeVM();
- v8::HandleScope scope(CcTest::isolate());
- LocalContext context;
- int use_counts[v8::Isolate::kUseCounterFeatureCount] = {};
- global_use_counts = use_counts;
- CcTest::isolate()->SetUseCounterCallback(MockUseCounterCallback);
- CHECK_EQ(0, use_counts[v8::Isolate::kBreakIterator]);
- v8::Local<v8::Value> result = CompileRun(
- "var iterator = Intl.v8BreakIterator(['en']);"
- "iterator.adoptText('Now is the time');"
- "iterator.next();"
- "iterator.next();");
- CHECK(result->IsNumber());
- CHECK_EQ(1, use_counts[v8::Isolate::kBreakIterator]);
-}
TEST(StringReplaceAtomTwoByteResult) {
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
