LGTM. Nice catch!
As discussed, the verification pass you're adding won't catch all possible
cases
of bad representations (notably: a required input representation might be
"None", meaning "I'll handle anything *except* actual 'None' coming in"),
but
it's probably impossible to catch such cases in an automated way, so let's
just
land what you have.
https://codereview.chromium.org/626383003/diff/1/src/hydrogen-representation-changes.cc
File src/hydrogen-representation-changes.cc (right):
https://codereview.chromium.org/626383003/diff/1/src/hydrogen-representation-changes.cc#newcode72
src/hydrogen-representation-changes.cc:72: DCHECK(req.IsNone());
On 2014/10/06 11:17:17, ulan wrote:
Without the HLoadRoot representation fix this assert triggers already
at
snapshot generation.
Acknowledged.
https://codereview.chromium.org/626383003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
