LGTM with comments.
https://codereview.chromium.org/614883003/diff/1/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/614883003/diff/1/src/objects.cc#newcode14918
src/objects.cc:14918: Handle<FixedArray> Dictionary<Derived, Shape,
Key>::BuildNewIterationIndices(
naming: BuildNewIterationIndices sounds confusingly similar to
GenerateNewInterationIndices. How about "BuildIterationIndicesArray"
instead?
https://codereview.chromium.org/614883003/diff/1/src/objects.cc#newcode14944
src/objects.cc:14944:
nit: two empty lines (doesn't presubmit complain?)
https://codereview.chromium.org/614883003/diff/1/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/614883003/diff/1/src/objects.h#newcode3586
src/objects.h:3586: // Values are direct indexes in the |HashTable|
array.
nit: s/indexes/indices/ for consistency.
https://codereview.chromium.org/614883003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
