Drive by comment.

http://codereview.chromium.org/193125/diff/1/3
File src/ia32/builtins-ia32.cc (right):

http://codereview.chromium.org/193125/diff/1/3#newcode940
Line 940: __ test(Operand(esp, (push_count + 1) * kPointerSize),
Immediate(0xc0000000));
You can combine the test for a non-negative smi into a single test:
  test(Operand(esp, (push_count + 1) * kPointerSize),
       Immediate(0x80000001));
  j(not_zero, &prepeare_generic_code_call);

http://codereview.chromium.org/193125

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to