Reviewers: Jakob, Igor Sheludko,

Message:
PTAL

Description:
Make asan and lsan make flags work like on the bots.

BUG=

Please review this at https://codereview.chromium.org/631763003/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files (+10, -5 lines):
  M Makefile


Index: Makefile
diff --git a/Makefile b/Makefile
index 70162df45a07d352187d31d6f998792efc491028..0ea68d12d977e138ed1e36ed165d91b9b165c4a0 100644
--- a/Makefile
+++ b/Makefile
@@ -137,13 +137,18 @@ endif
 ifeq ($(deprecationwarnings), on)
   GYPFLAGS += -Dv8_deprecation_warnings=1
 endif
-# asan=/path/to/clang++
+# asan=/path/to/llvm-build/Release+Asserts/bin
 ifneq ($(strip $(asan)),)
   GYPFLAGS += -Dasan=1
-  export CXX=$(asan)
-  export CXX_host=$(asan)
-  export LINK=$(asan)
-  export ASAN_SYMBOLIZER_PATH="$(dir $(asan))llvm-symbolizer"
+  export CC=$(asan)/clang
+  export CXX=$(asan)/clang++
+  export CXX_host=$(asan)/clang++
+  export LINK=$(asan)/clang++
+  export ASAN_SYMBOLIZER_PATH=$(asan)/llvm-symbolizer
+  TESTFLAGS += --asan
+  ifeq ($(lsan), on)
+    GYPFLAGS += -Dlsan=1
+  endif
 endif

 # arm specific flags.


--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to