On 2014/10/07 10:49:06, aandrey wrote:
https://codereview.chromium.org/630373003/diff/1/src/isolate.cc
File src/isolate.cc (right):
https://codereview.chromium.org/630373003/diff/1/src/isolate.cc#newcode2277
src/isolate.cc:2277: capture_stack_trace_for_uncaught_exceptions_ &&
value->IsJSObject()) {
I think we can drop the capture_stack_trace_for_uncaught_exceptions_
check:
1) will be still handled correctly below,
2) this flag may be false, but we could still have the stack collected.
https://codereview.chromium.org/630373003/diff/1/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):
https://codereview.chromium.org/630373003/diff/1/test/cctest/test-api.cc#newcode17965
test/cctest/test-api.cc:17965: CHECK_EQ(0, promise_reject_frame_count);
CHECK_EQ(-1, promise_reject_line_number);
New patch set addressing the comments uploaded.
https://codereview.chromium.org/630373003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
