LGTM.
https://codereview.chromium.org/637873002/diff/1/test/cctest/compiler/function-tester.h
File test/cctest/compiler/function-tester.h (right):
https://codereview.chromium.org/637873002/diff/1/test/cctest/compiler/function-tester.h#newcode43
test/cctest/compiler/function-tester.h:43:
function(NewFunction("(function(a,b){'use strict'; return 0;})")),
nit: Just use the empty function ... it looks confusing to have code
inside when it doesn't matter at all.
https://codereview.chromium.org/637873002/diff/1/test/cctest/compiler/function-tester.h#newcode152
test/cctest/compiler/function-tester.h:152: // foo me
nit: Hmm, it looks foo'ed already. :)
https://codereview.chromium.org/637873002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.