LGTM (just one comment to address).
https://codereview.chromium.org/640603003/diff/1/src/compiler/simplified-lowering.cc
File src/compiler/simplified-lowering.cc (right):
https://codereview.chromium.org/640603003/diff/1/src/compiler/simplified-lowering.cc#newcode876
src/compiler/simplified-lowering.cc:876: void
SimplifiedLowering::DoLoadElement(Node* node, MachineType output_type) {
Instead of passing the output_type as an argument we can just load it
from the NodeInfo using "GetInfo(node)->output". This makes the
signature simpler and also makes sure those two values never get out of
sync.
https://codereview.chromium.org/640603003/diff/1/src/compiler/simplified-lowering.cc#newcode901
src/compiler/simplified-lowering.cc:901: // TODO(turbofan): This is ugly
as hell!
I concur. :)
https://codereview.chromium.org/640603003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
