looking good, just one comment
https://codereview.chromium.org/624013005/diff/40001/src/runtime/runtime-classes.cc
File src/runtime/runtime-classes.cc (right):
https://codereview.chromium.org/624013005/diff/40001/src/runtime/runtime-classes.cc#newcode279
src/runtime/runtime-classes.cc:279: source,
Handle<Smi>::cast(start_position)->value(),
Some defensive programming here: check that start_position and
end_position are Smis and ThrowIllegalOperation otherwise.
https://codereview.chromium.org/624013005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
