https://codereview.chromium.org/637273002/diff/1/src/mips64/macro-assembler-mips64.cc
File src/mips64/macro-assembler-mips64.cc (right):
https://codereview.chromium.org/637273002/diff/1/src/mips64/macro-assembler-mips64.cc#newcode6070
src/mips64/macro-assembler-mips64.cc:6070:
base::MagicNumbersForDivision<uint32_t> mag =
On 2014/10/08 09:56:40, dusmil.imgtec wrote:
Can we instantiate template class with int32_t parameter here?
Will it cause to much trouble to change this?
Nope, the template parameter *must* be unsigned, otherwise all this
stuff is wrong. With full C++11 support I would have added
static_assert(std::is_unsigned<T>, "T must be unsigned");
to base::MagicNumbersForDivision, but we're not there yet, so there's
only a comment. Furthermore, we only have only instantiations for
uint32_t and uint64_t, so you would get a linker error reminding you of
that fact. :-)
https://codereview.chromium.org/637273002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
