https://codereview.chromium.org/633123002/diff/1/src/base/bits.h
File src/base/bits.h (right):
https://codereview.chromium.org/633123002/diff/1/src/base/bits.h#newcode107
src/base/bits.h:107: inline uint64_t CountTrailingZeros64(uint64_t
value) {
I think the result type of all these Count* functions should be
unsigned. Can you fix that for the 32-bit versions as well?
https://codereview.chromium.org/633123002/diff/1/src/base/utils/random-number-generator.cc
File src/base/utils/random-number-generator.cc (right):
https://codereview.chromium.org/633123002/diff/1/src/base/utils/random-number-generator.cc#newcode109
src/base/utils/random-number-generator.cc:109: }
This is undefined behaviour in C++. Should be:
uint64_t lo = bit_cast<unsigned>(Next(32));
uint64_t hi = bit_cast<unsigned>(Next(32));
return lo | (hi << 32);
https://codereview.chromium.org/633123002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
